Missing second parameter to vcs.update

sarugaku / passa

Resolver implementation and toolset for generating and interacting with Pipfile and Pipfile.lock.

ISC License

54 stars 12 forks source link

Missing second parameter to vcs.update #63

Open frostming opened 5 years ago

frostming commented 5 years ago

Testing case:

[[source]]
name = "pypi"
url = "https://pypi.org/simple"
verify_ssl = true

[packages]
requests = {git = "https://github.com/requests/requests", ref = "master"}

[dev-packages]

It is great that passa can resolve non-editable VCS deps. Iooking forward to replacing pip-tools.

uranusjr commented 5 years ago

Does the second argument always exist? We’ll need to make sure this works with older pip versions.

frostming commented 5 years ago

@uranusjr Oh no i didn't check that, it turns out it was introduced in v18.1 😢

pradyunsg commented 5 years ago

Yea, pip's VCS support code has been getting cleaned up and improved lately.

techalchemy commented 5 years ago

wait why are we still using this directly?