Closed uranusjr closed 4 years ago
Two discrepancies (circular
and fixed_circular
) are actually design decision differences. These are tracked in #25 to decide whether we want to offer the possibility of cycle detection.
The remaining three failures (complex_conflict
, shared_parent_dependency_with_swapping
, spapping_and_rewinding
) are all due to ResolutionTooDeep
. I tried increase the threshold (from 100 to 10000) without success. Will need to dive into them to know what’s actually going on (it’s just too complex, or if the resolver is stalling).
Interestingly not all “complex” fixtures fail, and two of the failed fixtures don’t seem that complex to me (shared_parent_dependency_with_swapping
is quite unwieldy though).
complex_conflict_unwinding
also fails if I use Molinilo’s visiting order (i.e. implement get_preference
the other way around). So maybe these complex fixtures are indeed complex for Molinilo?
Fixed the stalling in 12c5d6a! Just one to go… complex_conflict
.
Caught! fe8f0dc
Follow up of #21.
complex_conflict.json
shared_parent_dependency_with_swapping.json
spapping_and_rewinding.json
circular.json
complex_conflict_unwinding.json
conflict_on_child.json
deep_complex_conflict.json
fixed_circular.json
previous_conflict.json
pruned_unresolved_orphan.json
swapping_children_with_successors.json