search

sarugaku / resolvelib

Resolve abstract dependencies into concrete ones
ISC License
138 stars 31 forks source link

start_backtracking suggestion #81

Closed nadavwe closed 2 years ago

nadavwe commented 3 years ago

resolvelib changes to solve https://github.com/pypa/pip/issues/10210.

uranusjr commented 2 years ago

I’m +1 to the idea, but we should use a different function name. It’s not at all clear what the difference between start_backtracking and backtracking is (also the tense is inconsistent to other functions).

Maybe we can call this something like resolving_conflicts?

uranusjr commented 2 years ago

Uh, Travis is dead somehow. We should migrate to GitHub Action.

uranusjr commented 2 years ago

Could you rebase to or merge the latest master branch so we can apply the new GitHub Action checks?

uranusjr commented 2 years ago

Linter error!

nadavwe commented 2 years ago

Linter error!

sorry for that... :/

uranusjr commented 2 years ago

Nothing to be sorry about, the purpose of the CI being there to catch our errors 😛

uranusjr commented 2 years ago

Now test failures

nadavwe commented 2 years ago

Nothing to be sorry about, the purpose of the CI being there to catch our errors 😛

If I had run nox properly before committing, none of those problems would have occurred... that's why I'm sorry, needless ping-pongs. 🏓 😳

anyway, I ran nox now and it passes locally, I hope that CI agrees with me. 🤞

nadavwe commented 2 years ago

@uranusjr Thanks for the merge! when do you think resolvelib would be updated in pip so I can continue the integration in https://github.com/pypa/pip/pull/10258? or maybe I can do this update on my own and open a PR to pip?

uranusjr commented 2 years ago

Either would do, but first we'll need a new release here since pip's vendoring mechanism only allows public release. Since this does not introduce any backward incompatibility, I'll find some time to do a release this week.

uranusjr commented 2 years ago

0.8.1 released with this change.

nadavwe commented 2 years ago

opened https://github.com/pypa/pip/pull/10600 to incorporate the new version into pip.