search

sarugaku / resolvelib

Resolve abstract dependencies into concrete ones
ISC License
142 stars 31 forks source link

Fix mypy failures #94

Closed notatallshaw closed 2 years ago

notatallshaw commented 2 years ago

Related to https://github.com/python/mypy/issues/1153

This became an issue with mypy running on Python 3.10 (I guess collections.Mapping and collections.Sequence were finally removed).

It's causing mypy to fail in latest PRs: https://github.com/sarugaku/resolvelib/pull/93

uranusjr commented 2 years ago

Adding a compat.pyi file is probably more consistent to how typing is handled in the repo.

notatallshaw commented 2 years ago

Adding a compat.pyi file is probably more consistent to how typing is handled in the repo.

Oh yes, I missed because I forget about pyi files. Created a new PR: https://github.com/sarugaku/resolvelib/pull/95