search

sarugaku / shellingham

Tool to Detect Surrounding Shell
ISC License
228 stars 33 forks source link

use /proc instead of ps on linux #3

Closed glehmann closed 6 years ago

glehmann commented 6 years ago

ps is not always available in minimum linux install, like in docker containers. This change avoid to the need to install the procps package.

techalchemy commented 6 years ago

+1 for using the filesystem, was going to suggest the same. May want to handle walking /proc with a normalization library if we have a fallback like pathlib2 in here

uranusjr commented 6 years ago

Wow thanks! I thought about this as well but couldn’t find enough motivation to implement this. I will try to clean up a little and release this.

uranusjr commented 6 years ago

Also @glehmann I sent you a collaborate invitation so I can merge things much easier :p