search

sarugaku / shellingham

Tool to Detect Surrounding Shell
ISC License
227 stars 33 forks source link

Modern python #50

Closed JeppeKlitgaard closed 3 years ago

JeppeKlitgaard commented 3 years ago

This drops support for old Python versions.

Note that support is also dropped for Python 3.6, which strictly hasn't reached end-of-life yet, but is unsupported by the setl dependency. Since setl is only a dev dependency, 3.6 support could still be maintained, but I will leave that for @uranusjr to decide. I personally don't want to commit any time to getting 3.6 support set up, particularly since these changes contain no code changes but merely 'project health and maintainer sanity' changes, and pinning to 1.4 would be a more appropriate solution for downstream projects needing 3.6 support.

This limits the test matrix to 12 instances. Note also that MacOS now magically doesn't fail (no idea why). Windows CI has also been added.

This depends on the two prior pull requests.

--

Edit: Fix #47, close #48, close #49 (for convinience -- @uranusjr)

uranusjr commented 3 years ago

Leave 2.7 in and keep everything else in this PR, I’ll just merge this.

JeppeKlitgaard commented 3 years ago

I think this would suffer the same issues as 3.6 in that setl is 3.7+, and does not (at least according to pypi) support 2.7. For that reason, 2.7 tests will fail.

I can add back in the 2.7 classifier if you want, and just leave out the 2.7 from the testing matrix (since setl is only a dev dependency)

uranusjr commented 3 years ago

Ah, got it. Theoratically we can install setl against 3.7+ and point it to build shellingham against 2.7 (and 3.6), but that’s probably complicating things too much. Let’s just do this, if someone really wants us to test against 2.7, they can submit a PR for that 🙂