search

sarugaku / shellingham

Tool to Detect Surrounding Shell
ISC License
222 stars 33 forks source link

Add "nu" to _core.py to support detect NuShell #56

Closed gunungpw closed 2 years ago

gunungpw commented 2 years ago

Hello Thank you for your project, I am poetry user. Poetry use shellingham to detect shell for activating virtual environment. NuShell cannot the detected by poetry in Windows 10 show this PR fix that.

after the change shellingham can detect nushell:

D:\GitHub\demo-shellingham\demo_shellingham〉bat -p .\check.py                                                                                    03/24/2022 11:01:34 AM
import shellingham
print(shellingham.detect_shell())

D:\GitHub\demo-shellingham\demo_shellingham〉python .\check.py                                                                                    03/24/2022 11:01:43 AM
('nu', 'C:\\Program Files\\nu\\bin\\nu.exe')
D:\GitHub\demo-shellingham\demo_shellingham〉                                                                                                     03/24/2022 11:01:51 AM

Hope you all have a nice day 👍

gunungpw commented 2 years ago

Thank you 🙏

adrianstaniec commented 2 years ago

(when) will these be released in new package version? :)

uranusjr commented 2 years ago

Yes, once I get time for it. (Sorry it has been some busy months.)