search

sarugaku / shellingham

Tool to Detect Surrounding Shell
ISC License
222 stars 33 forks source link

Limit package installation to Python >= 3.7 #62

Closed hswong3i closed 2 years ago

hswong3i commented 2 years ago

python_requires = >=3.4 should be updated as python_requires = >=3.7, else Pypi will still list it as available for Python < 3.7.

Fixes #61

Signed-off-by: Wong Hoi Sing Edison hswong3i@pantarei-design.com

hswong3i commented 2 years ago

@JeppeKlitgaard @uranusjr update introduced by https://github.com/sarugaku/shellingham/pull/50 was incomplete, may I have your kindly review for this PR?

uranusjr commented 2 years ago

Is there anything in the code that is actually incompatible with 3.6 and lower? While unsupported, it does not mean we can’t allow older Pythons to install the version. It is still a good idea to set >= 3.7, but it affects whether we need to yank 1.5.0 from PyPI.

hswong3i commented 2 years ago

While unsupported, it does not mean we can’t allow older Pythons to install the version.

As a deb/rpm packager I couldn't understand should 1.5.0 also package for Python < 3.7 (e.g. Ubuntu 18.04, CentOS 7/8, openSUSE Leap 15.3/15.4), UNTIL integrate test together with other else python packages.

IMHO, if we already agree modernize Python support to >= 3.7 for on going development with https://github.com/sarugaku/shellingham/pull/50 (after 1.4.0, before 1.5.0), then please simply yank 1.5.0 from PyPI, update the line with python_requires = >=3.7, create a new release e.g. 1.5.1, then problem solved for everyone :-P

P.S. in case of my OBS packaging, I will keep 1.4.0 for all supported OS with Python >= 3.6, but disable 1.5.0 build for legacy OS with Python < 3.7, see https://build.opensuse.org/repositories/home:alvistack/sarugaku-shellingham-1.5.0. So I do need a clear message about your package supported Python version.

hswong3i commented 2 years ago

While unsupported, it does not mean we can’t allow older Pythons to install the version.

@frostming if we suppose 1.5.0 also working with Python >= 3.6, shall we enhance https://github.com/sarugaku/shellingham/commit/f26a196c583fc011f1c845af7cdcfe199150326d with Python 3.6 test cases, plus setting python_requires = >=3.76 precisely?

Else, could we merge this PR, yank 1.5.0 from PyPI, then release a hotfix version 1.5.1 with expected changes? We are now in a confusing status with Ubuntu 18.04 and CentOS 7/8 and openSUSE Leap 15.3/15.4 (still Python 3.6).