Fetch comments from copied cards

sarumont / py-trello

Python API wrapper around Trello's API

BSD 3-Clause "New" or "Revised" License

945 stars 330 forks source link

Fetch comments from copied cards #297

Closed bhrutledge closed 4 years ago

bhrutledge commented 4 years ago

I stumbled upon this while writing a backup script. For a copied card, everything that I wanted was there, except for the comments. It seems the action is different in that situation.

Some test output, prior this change:

### Sample Card

2019-05-07T16:00:00.000Z

Sample description

1 checklists
1 comments
1 attachments

### Copied Card

2019-05-07T16:00:00.000Z

Sample description

1 checklists
0 comments
1 attachments

After, the 0 comments becomes 1 comments.

bhrutledge commented 4 years ago

@sarumont Pardon the extra ping, but could this be merged and released? In the interim, I'm using my fork as a dependency, which means I can't install my project from PyPI.

sarumont commented 4 years ago

@bhrutledge Merged. Thanks for the contributions! I'll publish to pypi shortly...I need to get my new machine set up with my old GPG key. :)

bhrutledge commented 4 years ago

Thanks! I'll use the master branch of this repo until then.

sarumont commented 4 years ago

@bhrutledge OK, it's published to PyPi! Cheers!

bhrutledge commented 4 years ago

Thank you! In case you're curious, here's my project:

https://pypi.org/project/trello2md/ https://github.com/bhrutledge/trello2md