fix: failed to verify correctly signed bug. - Githubissues

sarvalabs / js-moi-sdk

JavaScript library to interact with MOI Protocol via RPC API

https://js-moi-sdk.docs.moi.technology/

Apache License 2.0

24 stars 2 forks source link

fix: failed to verify correctly signed bug. #83

Closed sarvalabs-harshrastogi closed 2 months ago

sarvalabs-harshrastogi commented 3 months ago

Resolve verification failure when signing messages with randomly generated wallets using the ECDSA_SECP256K1 signing algorithm.

closes #82

Changes

refactored Signer.verify method, if the public key is of length 33 bytes, it can be sliced to length of 32 bits.
updated the test cases with more robust onces.

Changes include

[x] Bugfix (non-breaking change that solves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

[X] I have assigned this PR to myself
[X] I have added at least 1 reviewer
[X] I have tested this code
[ ] I have updated the README and other relevant documents (guides...)