Facebook login detection logic in YumAuthController::actionLogin()

[GoogleCodeExporter]

Why should facebook login be dependent on existence of $_POST['YumUserLogin']?

i.e. shouldn't it be:
   if (is_set($_POST['YumUserLogin'])) {
      // try for LOGIN_BY_USERNAME, LOGIN_BY_EMAIL, ....
   } else {
      // try for LOGIN_BY_FACEBOOK
      if (Yum::module()->userType & USER_MODULE::LOGIN_BY_FACEBOOK) {
         $success=$this->loginByFacebook();
      }
      // if not, try login by twitter... etc.
   }

Vinod

Original issue reported on code.google.com by vinod.ku...@gmail.com on 22 May 2011 at 3:27

[GoogleCodeExporter]

I've been seeing some similar challenges when trying to adapt authentication to 
work with OpenId, which will not likely be dependent on the YumUserLogin model, 
or, which will require extending YumUserLogin to handle these other types of 
auth (or just gracefully bypass it)...

Original comment by JJHayes...@gmail.com on 25 May 2011 at 4:55

[GoogleCodeExporter]

yeah right...i did the work around added the faceook case as an independent 
case..now its working fine but still i have problem of empty values...the 
values that are send from facebook via post are empty 
singedRequest..session....all empty

Original comment by eliemaga...@gmail.com on 24 Dec 2012 at 11:33