search

sasa1977 / con_cache

ets based key/value cache with row level isolated writes and ttl support
MIT License
910 stars 71 forks source link

Fix compiler deprecation messages #51

Closed slashmili closed 5 years ago

slashmili commented 5 years ago

Calling super for GenServer callback handle_info/2 is deprecated since Elixir 1.7

The only think that I wasn't sure is should we emit error like handle_info/2 in GenServer or silently ignore messages that we don't expect?

sasa1977 commented 5 years ago

Thanks for the PR! I suggest we actually drop these catch-all clauses, because I can't think of a scenario where an unknown message might occur.

slashmili commented 5 years ago

Make sense 👍

The catch all functions have been removed!

sasa1977 commented 5 years ago

Thank you for contributing!

fenollp commented 5 years ago

Hi there! Can you cut v0.13.1 from this please?

sasa1977 commented 5 years ago

did it