sasa1977 / con_cache

ets based key/value cache with row level isolated writes and ttl support
MIT License
910 stars 71 forks source link

typo-in-doc: address small typo in acquire_lock_timeout #54

Closed RamanBut-Husaim closed 5 years ago

RamanBut-Husaim commented 5 years ago

Changes

Description

RamanBut-Husaim commented 5 years ago

@sasa1977 Hello. Could you please take a look? Thanks.

RamanBut-Husaim commented 5 years ago

@sasa1977 Hello. The build is failing with the following (https://travis-ci.org/sasa1977/con_cache/jobs/508210725):

** (ExDoc.Retriever.Error) ExDoc 0.19+ requires Elixir v1.7 and later. For earlier Elixir versions, make sure to depend on {:ex_doc, "~> 0.18.0"}

At the same time travis is configured to support Elixir 1.5 and Elixir 1.7.

  include:
    - otp_release: 19.0
      elixir: 1.5
    - otp_release: 20.1
      elixir: 1.6

Don't you think that it could make sense to reconfigure travis to build with elixir 1.7? I could do this as part of the PR.

Thanks.

sasa1977 commented 5 years ago

Thanks for the PR! Sorry it took me so long to merge it, somehow I completely missed the notification :(