sasa1977 / elixir-in-action

Code samples for Elixir in Action book
947 stars 199 forks source link

remove tool-versions file #25

Closed worming004 closed 2 years ago

worming004 commented 2 years ago

Elixir noob here,

After release of elixir 1.14, i've made the choice to install elixir with asdf instead of dnf. But after doing this, i've got trouble to understand why a vscode warning was saying to me I should install elixir 1.7. It took me 2 hours to just find out this file is making my current trouble.

In order to not share this bad (but inherent to noob usage like me) for newcomers to this language, removing this file could maybe save few hours of frustration for other noob developers.

conradwt commented 2 years ago

@worming004 I typically prefer to have a .tool-versions per project being that I have multiple projects that require different versions of Elixir and Erlang. Thus, I would simply recommend changing the version of Elixir within .tool-versions file instead of removing it. For consistency, I would also upgrade the Elixir version within the mix.exs file. For example, a recent version of my mix.exs sets it like so:

def project do
    [
      app: :flix,
      version: "0.1.0",
      elixir: "~> 1.14.0",
      ...
    ]
  end
worming004 commented 2 years ago

You are right, it would produce inconsistency between asdf & mix definition. As my want is to help next newbie, maybe we can create a readme warning about it instead of removing .tool-versions file ?

sasa1977 commented 2 years ago

Thanks for pointing this out! I think it's better to keep the .tool-versions file in the repo, as it makes the builds easier to reproduce. So instead I've updated the readme to mention this in 4ab14522f28470f8d59cbc5405b981342cb6cac5.

worming004 commented 2 years ago

Amazing ! Thanks