search

sasa1977 / exactor

Helpers for simpler implementation of GenServer based processes
MIT License
683 stars 23 forks source link

Support for Elixir 1.5 @impl #29

Closed carusso closed 6 years ago

carusso commented 7 years ago

It doesn't appear that there's a way to use the @impl directive with ExActor.

In a GenServer using ExActor, I have a terminate() function. If I use the @impl directive on it, I'm warned about not having the directive on the macro-generated call backs in the GenServer.

sasa1977 commented 7 years ago

I've added automatic generation of @impl attributes for callback functions generated by ExActor. Could you please try it out from this branch and let me know if it works for you?

carusso commented 6 years ago

I switched my dependency to the branch you referenced. As expected, the ExActor classes I had that contained other callbacks like terminate() and handle_info() began emitting warnings when compiled.

No other behavior changes were detected in my software, so it looks to me like your change was good. Thanks

sasa1977 commented 6 years ago

Thanks! I'm away this week, so not sure if I'll find the time to merge/publish. At the latest, I'll do it next week.

sasa1977 commented 6 years ago

FYI, I just published 2.2.4 to hex. Thanks for reporting this issue!