Change MODE to CERT_MODE in quick start example

sasa1977 / site_encrypt

Integrated certification via Let's encrypt for Elixir-powered sites

MIT License

462 stars 33 forks source link

Change MODE to CERT_MODE in quick start example #20

Closed cw789 closed 3 years ago

cw789 commented 3 years ago

OS env var MODE is conflicting with the one set by Elixir (elixir / iex).

cw789 commented 3 years ago

By the way. Thanks Saša for this cool library. I have some ideas but I'm not sure to get the time to contribute right now.

Key with ECDSA instead of RSA
Challenge via DNS (but not sure if it fits in here)

I'll keep this in my backlog.

sasa1977 commented 3 years ago

Thank you for the PR!

Adding support for EC keys would be great, PRs are welcome :-)

When it comes to DNS challenge, I think this might also be feasable, as long as interaction with a particular DNS is left out of scope. In other words, site_encrypt would provide a mock DNS for local dev & tests, while interaction with the real DNS would be the responsibility of the client.