search

sasa1977 / site_encrypt

Integrated certification via Let's encrypt for Elixir-powered sites
MIT License
462 stars 33 forks source link

Update deps #46

Closed axelson closed 1 year ago

axelson commented 1 year ago

No real breaking changes

NimbleOptions made 1.0 but the breaking change is:

Turn t:NimbleOptions.t/0 into an opaque type

Which doesn't affect site_encrypt

castore turned 1.0 but only made doc changes: https://github.com/elixir-mint/castore/commit/31f7505ed9706a8f259ce56755f83ff0aa3538a7

Since there's no breaking changes in those two packages I opted for more permissive versioning allowing the older or newer versions to be used.

The unit tests all pass (I didn't try the docker tests) and my https://github.com/axelson/vps is successfully running with this branch.

sasa1977 commented 1 year ago

I reverted the merge because it was failing on master, as well as locally after doing mix deps.unlock --all. I'm not sure if this was due to some flakiness or updated deps, but to be on the safe side I decided to undo for the moment.

sasa1977 commented 1 year ago

It turned out it was some flakiness which I'll try to look into later. I made a force push, and now your changes are back on the master. Thanks!

axelson commented 1 year ago

Great, thanks!