search

sasa1977 / site_encrypt

Integrated certification via Let's encrypt for Elixir-powered sites
MIT License
471 stars 34 forks source link

Bump version of Bandit #57

Closed oscar345 closed 9 months ago

oscar345 commented 9 months ago

The current version of Phoenix depends on a more recent version of Bandit, however, site_encrypt uses a older version of bandit. This makes it not possible to compile the application.

Resolving Hex dependencies...
Resolution completed in 0.112s
Because site_encrypt >= 0.5.0 depends on bandit ~> 0.6 and your app depends on bandit ~> 1.2, site_encrypt >= 0.5.0 is forbidden.
So, because your app depends on site_encrypt ~> 0.5, version solving failed.
** (Mix) Hex dependency resolution failed
sasa1977 commented 9 months ago

I think the way to go is bumping the dep requirement to "~> 1.0" in site_encrypt too. PR is welcome :-)

Hermanverschooten commented 9 months ago

Hi @sasa1977, this has already been adapted by a PR I did a while ago, but there was no new release in the mean time.

rkenzhebekov commented 9 months ago

I guess we need v0.5.1? I was able to run the bandit 1.2.0 with the master branch. There is a deprecation warning warning: SampleWeb.Endpoint.init/2 is deprecated, but it is discussed in here: https://github.com/sasa1977/site_encrypt/issues/58

sasa1977 commented 9 months ago

Published 0.5.1. The init deprecation requires more work and breaking changes, so I'll deal with that separately.