sasanrose / phpredmin

Yet another web interface for Redis
BSD 3-Clause "New" or "Revised" License
404 stars 96 forks source link

Make it available through composer #72

Closed drAlberT closed 7 years ago

drAlberT commented 8 years ago

It would be nice to be able to install phpredmin via composer ..

I'm using this project in faktiva/php-admin-tk and will be nice to require this prj in composer .. nowadays I have required it manually .. see my composer.json for reference

drAlberT commented 7 years ago

@sasanrose what do you think? I could implement it if you agree ..

sasanrose commented 7 years ago

@drAlberT can you please explain more about the requirements and your solution?

drAlberT commented 7 years ago

I'm simply asking to add a composer.json file in the root of the project in order to be able to submit it to packagist.org .. this way users could use this project with composer too, simply invoking composer require sasanrose/phpredmin

As the cost of this enhancement is very cheap I think it could be done .. I can do it for you if you want

sasanrose commented 7 years ago

@drAlberT Yeah I know about composer. But my point is that is not how you should use composer. That is not what composer is for. PHPRedmin is not really a requirement for any project. And current version of PHPRedmin does not have any specific dependencies itself that need composer.

luongvm commented 7 years ago

My thought: think Laravel & your website that used Laravel. While Laravel is available through composer, your website should not. This project is not a framework nor an package that offers functions to another package, it's the final product ready to be consumed.

If you wanted to include this inside your package of utilities, you may need to maintain a modified version yourself.

drAlberT commented 7 years ago

@sasanrose my project has .. :( So I have to maintain a fork just to have the project "cleaned" from composer.json file? ... ;(((

@joturako BTW, I don't understand why having the possibility to install phpredmin via composer create-projectcan't be taken into account too .. Yes, it is not a library, but it is a project .. and having some scriptable nice tool for deploying it should be cool too .. or, at least, should be not a trouble

drAlberT commented 7 years ago

OK, never mind .. I'll maintain a fork :)

Thanks anyway guys