[TASK] Make the data providers static

[oliverklee]

This is required in newer PHPUnit versions.

[oliverklee]

I have no idea where the gatherAssertTypes method comes from and would appreciate a pointer for that.

[sascha-egerer]

I have no idea where the gatherAssertTypes method comes from and would appreciate a pointer for that.

It's defined in the parent abstract class PHPStan\Testing\TypeInferenceTestCase

[oliverklee]

Ah, I see. For some reasons, my vendor folder was excluded in my PhpStorm.

[oliverklee]

We probably need to update PHPStan so TypeInferenceTestCase::gatherAssertTypes is static.

[oliverklee]

https://github.com/phpstan/phpstan-src/commit/ea2670a086f0f699b92dd6b2535504771054498c

[sascha-egerer]

We probably need to update PHPStan so TypeInferenceTestCase::gatherAssertTypes is static.

Ok, then we've finally found a reason in increase the dependency version ;)

[sascha-egerer]

Then lets reopen https://github.com/sascha-egerer/phpstan-typo3/pull/148 ?

[sascha-egerer]

Ok also fine like that. Thanks

[oliverklee]

I'd like to bump only the PHPStan dependency then. PR coming …

[oliverklee]

Okay, assertFileAsserts still is not static. We probably need to avoid calling it in a data provider. https://github.com/phpstan/phpstan-src/blob/1.11.x/src/Testing/TypeInferenceTestCase.php

[oliverklee]

Ah, wait …

[oliverklee]

Done: #150

[sascha-egerer]

Done: #150

this one is merged

[oliverklee]

Rebased and repushed.

[oliverklee]

Thanks! That was my bunch of changes for now. :-)