search

sascha-egerer / phpstan-typo3

TYPO3 CMS class reflection extension for PHPStan & framework-specific rules
MIT License
42 stars 22 forks source link

Update dependencies and make php-parse a dev dependency #160

Closed sascha-egerer closed 4 months ago

sascha-egerer commented 4 months ago

Closes #159

oliverklee commented 4 months ago

From my experience, it can avoid a lot of hassle to run PHP-CS-Fixer and PHPStan only with one PHP version, one TYPO3 version and one set of dependencies (highest vs. lowest) on CI as the results otherwise tend to vary somewhat.

sascha-egerer commented 4 months ago

From my experience, it can avoid a lot of hassle to run PHP-CS-Fixer and PHPStan only with one PHP version, one TYPO3 version and one set of dependencies (highest vs. lowest) on CI as the results otherwise tend to vary somewhat.

Actually I'm not a big fan of this but yes, it can become pretty complex. PHPStan itself does also have a special solution to support PHP 7.4. But i think... Time has come and PHP 7.4 support is ready to be dropped. I've now increased PHP requirement to 8.1 which should be fine for nearly everyone.

oliverklee commented 4 months ago

I've now increased PHP requirement to 8.1 which should be fine for nearly everyone.

I'm using this package in quite a few extensions that still support TYPO3 11LTS (and all PHP versions that TYPO3 11LTS supports, i.e., also PHP 7.4.). I'd like to be able to use the latest features and bugfixes and would appreciate either 7.4 support as long as TYPO3 11LTS is officially supported, or one last 7.4-compatible release before this PR gets merged. Thanks! :pray:

sascha-egerer commented 4 months ago

@oliverklee Here you go. I've now just adjusted some PHPCS rules so PHPCS is also happy when using PHP 7.4

oliverklee commented 4 months ago

@sascha-egerer Oh, thanks! :heart: