Added 2 new request attribute mappings for TYPO3 v13

sascha-egerer / phpstan-typo3

TYPO3 CMS class reflection extension for PHPStan & framework-specific rules

MIT License

42 stars 22 forks source link

Added 2 new request attribute mappings for TYPO3 v13 #165

Open derhansen opened 2 months ago

derhansen commented 2 months ago

Added frontend.page.information - see https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/RequestLifeCycle/RequestAttributes/FrontendPageInformation.html#frontend-page-information
Added frontend.cache.instruction - see https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/RequestLifeCycle/RequestAttributes/FrontendCacheInstruction.html#frontend-cache-instruction

sascha-egerer commented 1 month ago

We still need a way to make this TYPO3 version dependent as these types are now also valid in older TYPO3 versions with the current implementation.

derhansen commented 1 month ago

Can you elaborate what this means for this PR? Should we have different versions of the package for different TYPO3 versions or make requestGetAttributeMapping somehow TYPO3 major version aware? IMO, it would be fine to just add the types as is, since they just provide type mapping for the static code analysis and I doubt developers will use v13 only request attributes in <v13 projects.

But I'm also fine to just add the mapping to my custom phpstan.neon file :-)

sascha-egerer commented 1 month ago

I'm not yet sure how to solve the issue with supporting multiple TYPO3 versions. We do also have issues with the stubs where we already have a way to load them based on the TYPO3 version. But we really have to clean this up. I'll try to have a look at it soon.