Fix removing leading slash for root action, mutation and getter - Githubissues

sascha245 / vuex-simple

A simpler way to write your Vuex store in Typescript

MIT License

180 stars 15 forks source link

Fix removing leading slash for root action, mutation and getter #21

Closed geerpm closed 5 years ago

geerpm commented 5 years ago

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Root store's action/mutation/getter does not working because leading slash in name.

What is the current behavior? (You can also link to an open issue here)

// src/store.ts
const getterName = pBuilder.namespaces.join('/') + '/' + propertyName;
const mutationName = pBuilder.namespaces.join('/') + '/' + propertyName;
const actionName = pBuilder.namespaces.join('/') + '/' + propertyName;

What is the new behavior (if this is a feature change)?

// src/store.ts
const nsPath = pBuilder.namespaces.join('/');
const getterName = (nsPath ? nsPath + '/' : '') + propertyName;
// same changes for mutationName, actionName

sascha245 commented 5 years ago

Hi @geerpm,

Thanks for the fix, I will publish the changes as soon as possible

Sascha