search

saschakiefer / generator-openui5

yeoman generator for OpenUI5 applications and assets
Other
64 stars 17 forks source link

Can't add additional generator tests #15

Closed js1972 closed 10 years ago

js1972 commented 10 years ago

Due to a bug in generator-generator we can't add additional tests for the app/fiori/vew generators yet. Once the fix is in we can write more robust tests.

js1972 commented 10 years ago

https://github.com/yeoman/generator/pull/451

saschakiefer commented 10 years ago

I see the point. I was wondering though, if we shouldn't have a separate test in a separate file for the Fiori App?

js1972 commented 10 years ago

We can try that. Might work. I'm used to grouping tests together in the one file. That might avert the bug so long as the helpers does a "cd .." between files. generator-generator will be updated in npm anyway now anyway.

saschakiefer commented 10 years ago

Fair enough. Do you think you get this done, before Bali? If so, I would hold back releasing 0.2.0 until you implemented it, otherwise I push it out and we can add it afterwards (or fix it by myself)

js1972 commented 10 years ago

Please push it out. Its 11:30 at night here and I'm flying out with the family first thing in the morning. Adding more unit tests won't help it now - but it will help with future changes to make sure nothing is broken. Next time I get to play around with it I'll grab the latest generator-generator and add some more tests....

I need to learn and play around more with concat and minimisation as well and how it works / applies to ui5 apps. Would be good to have a grunt / gulp workflow to take what you generate to prod ready. Ui5 does a bunch of seemingly unnecessary get requests as well - I'd love to work out a way stop them but that's probablyba job for your mates in the ui5 team.....

On Mon, Jan 6, 2014 at 11:14 PM, saschakiefer notifications@github.com wrote:

Fair enough. Do you think you get this done, before Bali? If so, I would hold back releasing 0.2.0 until you implemented it, otherwise I push it out and we can add it afterwards (or fix it by myself)

Reply to this email directly or view it on GitHub: https://github.com/saschakiefer/generator-openui5/issues/15#issuecomment-31655352

js1972 commented 10 years ago

With yeoman-generator >= 0.16.0 this is fixed. Just do a "npm update -g yo".

saschakiefer commented 10 years ago

I also updated the version number in the dependency area in the configuration file.