saschakiefer / generator-openui5

yeoman generator for OpenUI5 applications and assets
Other
64 stars 17 forks source link

Application Generator dependent on View Generator #19

Closed saschakiefer closed 10 years ago

saschakiefer commented 10 years ago

The application generator is currently dependent on the view generator. The Application.js file (which belongs to the application templates) is copied in the view generator to the application (because the view name which is called in the Application.js file is only known in the view generator). This should be changed.

Possibilities:

js1972 commented 10 years ago

I wonder if developers will want to create application.js based apps going forward given that the direction is leaning toward the component model?I reckon we hard-code the view name.

On Mon, Jan 6, 2014 at 11:59 PM, saschakiefer notifications@github.com wrote:

The application generator is currently dependent on the view generator. The Application.js file (which belongs to the application templates) is copied in the view generator to the application (because the view name which is called in the Application.js file is only known in the view generator). This should be changed. Possibilities:

  • Use a hard coded name in Application.js

* Copy Application.js in the application generator and change it in the view generator to the final view name

Reply to this email directly or view it on GitHub: https://github.com/saschakiefer/generator-openui5/issues/19

saschakiefer commented 10 years ago

That's why we have issue #7. I'm going to change that to a component in the next release. But the issue remains the same (instead of Application.js, it would be Component.js).

But I'm thinking as well to start with a hard coded view name and maybe extend it, if needed

js1972 commented 10 years ago

Might be worth checking out how the backbone generator does a similar thing...

On Tue, Jan 7, 2014 at 5:20 PM, saschakiefer notifications@github.com wrote:

That's why we have issue #7. I'm going to change that to a component in the next release. But the issue remains the same (instead of Application.js, it would be Component.js).

But I'm thinking as well to start with a hard coded view name and maybe extend it, if needed

Reply to this email directly or view it on GitHub: https://github.com/saschakiefer/generator-openui5/issues/19#issuecomment-31723081

js1972 commented 10 years ago

This is cool but has removed the ability to generate an XML view when scaffolding a classical app. I'll re-open. We've both been making independent changes so I won't touch anything till the current pull-request is merged into develop at which point I'll sync up again...

saschakiefer commented 10 years ago

It was more intentionally, but maybe I oversimplified. On 2nd thought, I'm going to add the XML view option again