search

saschakiefer / generator-openui5

yeoman generator for OpenUI5 applications and assets
Other
64 stars 17 forks source link

Dynamic Port for the grunt serve task #34

Closed saschakiefer closed 10 years ago

saschakiefer commented 10 years ago

We should have an option to set the port of the grunt serve task in order to avoid conflicts of already running servers (defaulted to 8080)

js1972 commented 10 years ago

I can do this very easily, but I guess it raises the question about how many options we should provide as opposed to the user manually changing the port.? For now lets add it in as another prompt at the end (defaulting to 8080): "Select port for serving your app?". If the number of prompts starts to get unwieldly we can refactor later. ;-)

js1972 commented 10 years ago

Done in spa branch of fork.

saschakiefer commented 10 years ago

Don't think we need more. I just find, that this is one easily collides with user set ups (e.g. Tomcat) and thus would annoy people to have them changed every time. Agree on the refactoring if needed.

js1972 commented 10 years ago

I've actually got some code floating around somewhere that dynamically finds a free port.  ;-)Anyway - I've enabled the "choose your port" option. It's in the current pull request.

On Sat, Feb 1, 2014 at 5:06 PM, saschakiefer notifications@github.com wrote:

Don't think we need more. I just find, that this is one easily collides with user set ups (e.g. Tomcat) and thus would annoy people to have them changed every time. Agree on the refactoring if needed.

Reply to this email directly or view it on GitHub: https://github.com/saschakiefer/generator-openui5/issues/34#issuecomment-33867092