search

saschakiefer / generator-openui5

yeoman generator for OpenUI5 applications and assets
Other
64 stars 17 forks source link

Live-reload - make it optional? #36

Closed js1972 closed 10 years ago

js1972 commented 10 years ago

Live-reload might be a bit confusing to newbies so lets make it an optional extra.

Question - what about the WATCH task? Its probably in the same boat and maybe that should be an option as well?

Build process (list of checkboxes): -- Enable dynamic watching of files to Lint and run tests? (default true) -- Enable Live-reloading of the browser? (default true)

?

js1972 commented 10 years ago

Live-reload prompt added to generator in my fork in livereload branch. I have left the comments in Gruntfile.js however, as this explains how the user can enable a proxy. Should we take this out? Maybe remove the comments and add instructions in the readme instead. => I think I will do this...

saschakiefer commented 10 years ago

I would leave the proxy in the Gruntfile as comment. I think it's a very common scenario in UI5 Apps, that one needs that when developing serious applications. So it shouldn't be much effort to include that.

js1972 commented 10 years ago

Ok. Will leave and maybe just switch to a comment block instead of line comments to try and avoid the stupid mixed space / tab issue.   ;-)

On Sat, Feb 1, 2014 at 4:45 PM, saschakiefer notifications@github.com wrote:

I would leave the proxy in the Gruntfile as comment. I think it's a very common scenario in UI5 Apps, that one needs that when developing serious applications. So it shouldn't be much effort to include that.

Reply to this email directly or view it on GitHub: https://github.com/saschakiefer/generator-openui5/issues/36#issuecomment-33866755

saschakiefer commented 10 years ago

I would leave the watch task in (also planned to mention it in the blog). Main reason is, that for the live reload you need additional installation steps, thus it's mor complicated. The watch task is straight forward and I don't see no harm to have it in there.

js1972 commented 10 years ago

Typically people just use a browser extension for live-reload but you can use a connect middleware to insert the live-reload script as well. Anyway will leave as you've described for now.  ;-)

On Sat, Feb 1, 2014 at 4:59 PM, saschakiefer notifications@github.com wrote:

I would leave the watch task in (also planned to mention it in the blog). Main reason is, that for the live reload you need additional installation steps, thus it's mor complicated. The watch task is straight forward and I don't see no harm to have it in there.

Reply to this email directly or view it on GitHub: https://github.com/saschakiefer/generator-openui5/issues/36#issuecomment-33866957