search

saschakiefer / generator-openui5

yeoman generator for OpenUI5 applications and assets
Other
64 stars 17 forks source link

JSHint reports errors (in generated app) with mixed spaces/tabs inside comments event though smarttabs is set in .jshintrc #39

Closed js1972 closed 10 years ago

js1972 commented 10 years ago

It reports errors in the Gruntfile.js where I have added comments to describe how to enable proxying of resources. It just seems ridiculous to me that any linter would parse comments. According to the issues on the JSHint repo the owner wants this for consistency - which I think it stupid! The only answer is to enable smarttabs: true. But this does not seem to work on the generated Gruntfile.js.

saschakiefer commented 10 years ago

Yes, I know that. I find it especially annoying, when you comment code blocks. An alternative is also to put it in block comments /* */. That's what I usually do.

js1972 commented 10 years ago

Is the issue only with line comments: // ?

Anyway - I think its better to remove the comments to keep it a nice clean file as they are actually instructions which would be best in the readme or a wiki page - what do you think?

On Sat, Feb 1, 2014 at 4:42 PM, saschakiefer notifications@github.com wrote:

Yes, I know that. I find it especially annoying, when you comment code blocks.

An alternative is also to put it in block comments /* */. That's what I usually do.

Reply to this email directly or view it on GitHub: https://github.com/saschakiefer/generator-openui5/issues/39#issuecomment-33866700

js1972 commented 10 years ago

Done