search

saschakiefer / generator-openui5

yeoman generator for OpenUI5 applications and assets
Other
64 stars 17 forks source link

Improve tests on the scaffolded tiles app + minor chores #48

Closed js1972 closed 10 years ago

js1972 commented 10 years ago

Added some tests with the help of the cheerio npm module to check the scaffolding of index.html. Checking for correct component namespace, UI5 location and title.Cheerio is a handy little helper that gives us jQuery like parsing of the file. Removed type attribute from script tags as they are no longer required with html5 (defaults to text/javascript). Added the jshint global definition for require in test-load.js which was missing.

These additional tests only apply to the scaffolding of the tiles app. If they look okay I'll add to all the other app options and look at checking the scaffolded gruntfile as well which will be a bit more difficult.

saschakiefer commented 10 years ago

Should we close that, since it's an ongoing task? I think it would be a constant "mission" to improve tests. What do you think?