Slashes in prompt answers which result in values in package.json cause npm install to fail

saschakiefer / generator-openui5

yeoman generator for OpenUI5 applications and assets

Other

64 stars 17 forks source link

Slashes in prompt answers which result in values in package.json cause npm install to fail #51

Open js1972 opened 10 years ago

js1972 commented 10 years ago

If you have slashes in the text answers to the prompts that are writing into the package.json. npm install will fail.

We can easily escape them out - is it worth it..?!?

saschakiefer commented 10 years ago

Do you have an example, where that would become relevant? Doe sthat happen in the Application Name/ Description?

js1972 commented 10 years ago

I'll have to test again as its been a while and I've since lost those neurons... I know its happened a couple of times where I've just done a typo and accidentally entered a slash into some parameters and the generator has a minor heart-attack.

saschakiefer commented 10 years ago

:+1: Maybe, then we should change it for the sake of robustness.