saschanaz / jxl-winthumb

A JPEG XL (*.jxl) thumbnail handler for Windows File Explorer.
ISC License
375 stars 17 forks source link

cpu burn when enable #4

Closed raysar closed 3 years ago

raysar commented 3 years ago

Hello, The dll works but it's super slow. And there is some freeze of explorer. After enable it, the process COM Surrogate take 100% of 1 thread of my cpu, all the time.

Taskmgr_MIIVIXSafN

saschanaz commented 3 years ago

I sometimes also see some files cause this, but haven't investigated yet. Could you provide the file that causes this?

raysar commented 3 years ago

i don't know, i can kill explorer and com surrogate, process restart alone and burn. I have all type of jxl (anamate, 16bits, jpeg recompress, progressive, 24mpx etc) on my folder, maybe with old encoder :D I switch to the https://github.com/mirillis/jpegxl-wic project, but now i have infinite charging and zero thumbnails, even jpeg png mp4 :D

Could you create a release with the lastest jxl decoder? :D Maybe it works?

saschanaz commented 3 years ago

Hmm, I will try that this weekend. If that still doesn't help, then we can put the files into a subfolder one by one so that we can see which specific file is causing issue.

raysar commented 3 years ago

Yes i will test it and send you "problematic file"

This command is enought to remove completely the program? regsvr32 /u jxl_winthumb.dll

saschanaz commented 3 years ago

Yup, that command should do the work.

saschanaz commented 3 years ago

Note that uninstalling does not unload the dll, and you may need to sign out to actually unload it.

saschanaz commented 3 years ago

Just posted a new release, could you check it again?

raysar commented 3 years ago

Yes now dll WORKS, you're the best! :p

Some jxl don't decode, for example, 16 bits files, progressive jxl and file encoded with "--noise 1" (same problem with old chrome canary).

jxl.zip

saschanaz commented 3 years ago

Yay, good to hear that!

I see those files decoded on my machine, am I missing something? (Ignore alien.jxl 😀)

image

Edit: Ah no, I have unsubmitted changes, maybe that fixed the bug.

saschanaz commented 3 years ago

Just published another release, please give it a try 😉

raysar commented 3 years ago

With your last dll, all jxl display ! Thank you !

saschanaz commented 3 years ago

👍👍 Thank you for reporting the issues!