search

saschanaz / jxl-winthumb

A JPEG XL (*.jxl) thumbnail handler for Windows File Explorer.
ISC License
375 stars 17 forks source link

The stuff of nightmares. #6

Closed Neltulz closed 3 years ago

Neltulz commented 3 years ago

Tested in Windows Explorer and Directory Opus OS: Windows 10 Pro 64bit JXL-Winthumb version: v0.1.9 JXL version: 0.3.7 JXL settings used: "X:\ProgramFiles\JpegXL\cjxl.exe" {filepath} -d 2 -s 7 -j {filepath$|noext}_(JPEGXL_d2_s7).jxl

Horrifying result: Clipboard Image

Expected result: Well, definitely NOT what you see above on the right.

Original Image: IMG_20210704_184031 - Copy

Converted to JXL: IMG_20210704184031 - Copy(JPEGXL_d2_s7)_jxl.zip

saschanaz commented 3 years ago

Hmm, again this is Directory Opus specific issue as #1 was. I have no way to debug it since it's not open source (and my trial is over and I don't really want to pay), could you contact its devs instead?

Neltulz commented 3 years ago

Hmm, again this is Directory Opus specific issue as #1 was. I have no way to debug it since it's not open source (and my trial is over and I don't really want to pay), could you contact its devs instead?

I tested it in Explorer as well. The issue occurs in Explorer.

I made that clear in line 1.

Neltulz commented 3 years ago

image

As you can see, this issue is not limited to Directory Opus.

saschanaz commented 3 years ago

Thanks, but that doesn't seem like the original File Explorer, what are you using and how can I make the preview size that big?

Neltulz commented 3 years ago

image

Neltulz commented 3 years ago

Thanks, but that doesn't seem like the original File Explorer, what are you using and how can I make the preview size that big?

image

saschanaz commented 3 years ago

Hmm, still can't repro, but it could be a hardware dependent issue. I'll try updating libjxl, but before that, does it happen when the preview size is small?

Neltulz commented 3 years ago

image

saschanaz commented 3 years ago

Thanks again. Does it also happen if you copy-paste the file while the preview size is kept small? (I've seen File Explorer just reuses previous larger thumbnail when changing preview size. Copy-pasting makes sure it gets a new thumbnail.)

Neltulz commented 3 years ago

Just installed jxl-winthumb on my SECONDARY Ryzen PC.

Result:

image

Neltulz commented 3 years ago

Thanks again. Does it also happen if you copy-paste the file while the preview size is kept small? (I've seen File Explorer just reuses previous larger thumbnail when changing preview size. Copy-pasting makes sure it gets a new thumbnail.)

Considering, I just installed JXL-Winthumb on a secondary PC, that previously did not have JXL-Winthumb installed at all, I think it's safe to say that the issue lies with JXL-Winthumb, and not something about my computer hardware or computer software.

Also, I copied the images from my primary PC onto my secondary ryzen PC, into a completely separate folder, excluding the Thumbs.db file, so that Explorer would generate a new thumbnail image for the JXL.

Neltulz commented 3 years ago

Also, the hardware is about as different as they could possibly be. My primary PC uses an Intel core i7 6700k quad with an nvidia RTX 2070 super. My secondary PC uses a ryzen 3700x with a dedicated AMD Radeon RX550 gpu. The hardware is completely different.

saschanaz commented 3 years ago

I wanted to check whether the newly generated small thumbnail still has the same issue. By hardware-depedendent I mean a libjxl side bug (that could have been fixed in the latest version).

Anyway I'm doing libjxl update, I'll ping you when a new release happens.

Neltulz commented 3 years ago

Thanks again. Does it also happen if you copy-paste the file while the preview size is kept small? (I've seen File Explorer just reuses previous larger thumbnail when changing preview size. Copy-pasting makes sure it gets a new thumbnail.)

image

I tried copying the images with Medium Icons, into a new folder, and it generated a new thumbnail for the JXL. Still appears messed up.

Did I follow your instructions correctly?

saschanaz commented 3 years ago

Thank you for all the followups! I suspect it's a libjxl thing and hope the ongoing update fix your issue. (Will make it within an hour, unless something happens)

Neltulz commented 3 years ago

Thank you for all the followups! I suspect it's a libjxl thing and hope the ongoing update fix your issue. (Will make it within an hour, unless something happens)

No problem, do not rush! :) I will probably be asleep, so definitely relax, take your time. Appreciate all of the hard work you're doing on this.

saschanaz commented 3 years ago

https://github.com/saschanaz/jxl-winthumb/releases/tag/v0.1.10

Neltulz commented 3 years ago

That appears to have fixed the issue! Thanks! :)

image

saschanaz commented 3 years ago

Great! Closing as such 👍