search

saschpe / android-customtabs

Chrome CustomTabs for Android demystified. Simplifies development and provides higher level classes including fallback in case Chrome isn't available on device.
Apache License 2.0
383 stars 49 forks source link

Proguard is weak #25

Open androidmitry opened 6 years ago

androidmitry commented 6 years ago

Hello everyone. Thanks for creating this awesome library. I faced some unusual problem. Proguard doesn't obfuscate code as I expect. I reviewed [https://github.com/saschpe/android-customtabs/blob/master/customtabs/proguard-rules.pro](Proguard rules) in the library and it looks like that this rule is too generic -keep public class * { public protected *; } This rule forces Proguard to keep all classes with public and protected fields. Thanks for help.

sergivonavi commented 5 years ago

Completely agree with it. Spent several hours until I figured this out. @saschpe can you, please, change this rule?

igorvilela28 commented 5 years ago

Is this issue gonna be addressed? I lost an entire morning trying to figure out why my proguard wasn't obfuscating anything.

This library works very well, but it completely disables the proguard.

saschpe commented 5 years ago

Version 2.0.3 should fix that. The library shipped the proguard-rules.pro file used to build it's release flavor. That wasn't actually necessary.