search

saschpe / libvirt-hook-qemu

Libvirt hook for setting up iptables port-forwarding rules when using NAT-ed networking.
236 stars 69 forks source link

Included port range support #14

Closed davidcassany closed 8 years ago

davidcassany commented 8 years ago

I have included a new property in schema (port_range), updated the script and changed file naming convention, as I am using it for LXC not for QEMU, I think it would be better to call the script something else (as the same one works either for lxc or qemu) and then do the trick by making two soft links (qemu and lxc). However that's just an idea.

Cheers, David

saschpe commented 8 years ago

Looks good to me though I don't have the chance to really test this... @bronson how about you?

bronson commented 8 years ago

Sorry for the delay, haven't thought about this script for months (which is a good sign).

@davidcassany, just curious: how will you use this feature?

It would be nice to see the qemu->hooks rename in a separate PR. That seems a change worth discussing on its own. For example, you've run it on lxc?

Also, it's complex enough that, yeah, it needs automated tests.

With those changes, this sounds OK to me.

bronson commented 8 years ago

Ah, #13 describes the use.

bronson commented 8 years ago

This PR should include docs in the README of course... That should be easy.

saschpe commented 8 years ago

@bronson i sort of agree but it has been open for quite a while too...

tgwaste commented 4 years ago

I know this is old but an example of this sure would be awesome. I cant figure it out for the life of me.