search

saschpe / libvirt-hook-qemu

Libvirt hook for setting up iptables port-forwarding rules when using NAT-ed networking.
233 stars 69 forks source link

Multiple network interfaces for a vhost? #31

Open jamesyoungman opened 5 years ago

jamesyoungman commented 5 years ago

Is there any way to support multiple IP adresses for a VM?

I would like to do this because I need to have more than one Apache virtual host on a VM and allow access to port 80 on both addresses. I need to do that because one of the vhosts needs to be configured with some insecure settings ("HttpProtocolOptions Unsafe") which I wouldn't want to apply to the default vhost.

Right now I don't think I can have two IP addresses because the hooks script assumes that there is exactly one possible value of private_ip per VM, I think.

I can't make one of the Apache vhosts a CNAME (and thus need only one IP address) because this is against best practice for Apache httpd (see https://httpd.apache.org/docs/2.4/dns-caveats.html).

Doralitze commented 3 years ago

I also do require multiple IP Addresses per VM but with different port forwards. So I'll hack something and make a PR about it. As my understanding goes this should be as simple as allowing the hook for a particular VM to handle multiple sections as different addresses are handled by different rule sets as far as iptables goes.

There are multiple PR which aren't addressed but others are. Are there any rules about that?

saschpe commented 3 years ago

Well, I stopped using this tool a while ago so I can't really test bigger PRs. There are quite a few other people who do however and sometimes they chime in. I do tend to merge those that are straightforward to review though.

Doralitze commented 3 years ago

Thanks for the quick answer. I'll write those changes for myself then and maybe they'll end up being upstreamed. We'll see.

Doralitze commented 3 years ago

I've created a pull request (#34) addressing this issue. I hope it might get merged.