search

saschpe / libvirt-hook-qemu

Libvirt hook for setting up iptables port-forwarding rules when using NAT-ed networking.
236 stars 69 forks source link

minimize json before parsing, allows comments #9

Closed bronson closed 8 years ago

bronson commented 8 years ago

An attempt at solving #3.

There were a few ways of going about this... Using simple regexes had some pretty obvious downsides (breaking on key: "a // b" for example). Requiring the user to install pip packages would be overkill.

This seemed like the best middle ground.

saschpe commented 8 years ago

Not quite JSON but I see the point :-)

About pip packages, makes sense for me. Otherwise this project would need a proper setup.py. But the term overkill fits quite well there ;-)

bronson commented 8 years ago

updated to most recent master. curious what you think, mergeable or no?