saseungmin / Recoil_ToDo

Todo📆 application created using Recoil and React ⚛️
https://saseungmin.github.io/Recoil_ToDo/
MIT License
20 stars 1 forks source link

[Refactoring] Overall Auth Structure Change #48

Closed saseungmin closed 3 years ago

saseungmin commented 3 years ago
codecov[bot] commented 3 years ago

Codecov Report

Merging #48 (9ac85ee) into main (74ef170) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #48   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           41        44    +3     
  Lines          409       466   +57     
  Branches        57        63    +6     
=========================================
+ Hits           409       466   +57     
Impacted Files Coverage Δ
src/components/common/InjectTestingRecoilState.jsx 100.00% <ø> (ø)
src/components/user-info/AuthButton.jsx 100.00% <ø> (ø)
src/recoil/auth/atom.js 100.00% <ø> (ø)
src/App.jsx 100.00% <100.00%> (ø)
src/components/auth/AuthModalForm.jsx 100.00% <100.00%> (ø)
src/components/auth/AuthStatus.jsx 100.00% <100.00%> (ø)
src/components/auth/LoginForm.jsx 100.00% <100.00%> (ø)
src/components/auth/RegisterForm.jsx 100.00% <100.00%> (ø)
src/components/common/LoadingSpinner.jsx 100.00% <100.00%> (ø)
src/components/user-info/LoggedInUserInfo.jsx 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 74ef170...9ac85ee. Read the comment docs.

saseungmin commented 3 years ago

거의 모든 컴포넌트 및 구조를 변경하였다. 처음 리코일을 해보다보니 구조를 잘 못 설계했던거 같다. 시간이 오래걸렸고, 하나의 PR을 너무나도 크게 잡아버렸다..