Confirm before closing tab

sasha-alias / sqltabs

Rich SQL client for Postgresql, MySQL, MS SQL, Amazon Redshift, Google Firebase (Firestore)

https://www.sqltabs.com

GNU General Public License v3.0

803 stars 57 forks source link

Confirm before closing tab #27

Closed utopic-men closed 8 years ago

utopic-men commented 8 years ago

The new tab button is not so far ! :)

egor-bayandin commented 8 years ago

Pls. do it configurable :)

sasha-alias commented 8 years ago

Personally I don't like dialogs. Though I several times pressed Command+W instead of Command+E and it feels annoying. So I prefer to have an ability to restore the closed tab with its content instead of having confirmation dialogs. There is a corresponding item for this

utopic-men commented 8 years ago

Solution : make it configurable (default behaviour : no dialog) as @egor-bayandin suggested.

sasha-alias commented 8 years ago

I'm trying to avoid a configurable behaviour :) The reasons are:

configurable behaviour is hard to support and it complicates the product
configurable behaviour means a bad design of UX and it's a poor fix of it

So I agree, there is an issue with closing tabs, but I think restoring should fix it. This is exactly how web-browsers do it, so should be OK I hope. Although can't promise it to be implemented soon, since I'm busy with another things atm.

utopic-men commented 8 years ago

It's OK !

Thank you for your great and promising app !