sasha-alias / sqltabs

Rich SQL client for Postgresql, MySQL, MS SQL, Amazon Redshift, Google Firebase (Firestore)
https://www.sqltabs.com
GNU General Public License v3.0
803 stars 57 forks source link

Feat/settings page #86

Closed maury91 closed 7 years ago

maury91 commented 7 years ago

I've created a settings page ( like the Atom one ).

The settings page appears if you digit on the connection string "about:settings" or if you open it from the menu. In case you open from the menu it will check if one is already open (I tried to make possible to have only 1 settings tab open, even if more than 1 doesn't conflict).

I made some minor changes:

screen shot 2017-03-17 at 23 21 42
sasha-alias commented 7 years ago

@maury91 Great contribution! Thank you very much for your work on this PR and the others you've sent recently. Really appreciated!

maury91 commented 7 years ago

@sasha-alias You welcome, I should thank you for the entire app, it make my job easier

sasha-alias commented 7 years ago

hey @maury91 for some reason settings tab keyboard shortcut Cmd+, doesn't work for me . Trying to understand if it's my local issue.. Does it work for you?

maury91 commented 7 years ago

hi @sasha-alias unfortunately, doesn't work neither on mine, I wasn't able to find any information online, so I just leave it as a placeholder to know which one should be the usual combination

sasha-alias commented 7 years ago

it looks like Editor captures this keys combination and doesn't allow to propagate further, when focus is out of the editor it works.

sasha-alias commented 7 years ago

found https://github.com/sasha-alias/sqltabs/commit/b4aea5240db39f82afeaecac83a4033fd41cc0d5

thanks for the help