search

sasha-s / go-deadlock

Online deadlock detection in go (golang)
Apache License 2.0
1.04k stars 76 forks source link

fix: fix RUnlock timing #10

Closed orisano closed 6 years ago

orisano commented 6 years ago

Is it mistake? Currently, deadlock.RLock executes PostUnlock before RUnlock.

This change is Reviewable

codecov[bot] commented 6 years ago

Codecov Report

Merging #10 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #10   +/-   ##
======================================
  Coverage    87.2%   87.2%           
======================================
  Files           2       2           
  Lines         211     211           
======================================
  Hits          184     184           
  Misses         19      19           
  Partials        8       8
Impacted Files Coverage Δ
deadlock.go 86.27% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 89fc815...35e4527. Read the comment docs.

sasha-s commented 6 years ago

Thanks!

:lgtm:

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable