search

sashaafm / exads

Algorithms and Data Structures collection in Elixir
83 stars 12 forks source link

Feat/repo update - Updates to elixir 1.4.0 #23

Closed remshams closed 7 years ago

remshams commented 7 years ago

Hello,

I needed an AVL tree in elixir (which is how I found that repository). In preparation to the implementation I've updated to repo to elixir 1.4.0 as well as the deps.

With that some test- and compiler warning issues did appear which I've tried to fix. The warnings still displayed seem to be in the deps; not sure how to fix them (I'm still somehow new to elixir).

In case you have interest in the contribution (and the AVL tree implementation) please have a look at it. Otherwise I'd keep working in my fork...

sashaafm commented 7 years ago

Hello @remshams, thank you so much for the PR. Have you finished this one? May I merge it?

Will the AVL tree come in another PR?

Thanks! Let me know if you need anything.

remshams commented 7 years ago

Yes, the updates are just a preparation. I'd create a separate PR for the AVL tree implementation as soon as the first version/draft is finished (as a "MVP").

The implementation will include some structural changes regarding the existing BST implementation (like adding a struct for the nodes, functions for augmenting the tree).

The first version could then be seen as a suggestion/discussion base for further optimizations...