search

sashaafm / exads

Algorithms and Data Structures collection in Elixir
83 stars 12 forks source link

Add `credo` for static code analysis #6

Closed ghost closed 8 years ago

ghost commented 8 years ago

This dependency unlocks the mix credo set of tasks for linting the codebase. I did not add a .credo.exs -- we can always add that later as needed.

NobbZ commented 8 years ago

I do like this one. I use credo by myself in my projects.

@uranther have you checked already if current codebase is OK according credos defaults?

Also I do fear merge conflict with #5, but that should be very easily resolvable. It's only a single file mix.exs, perhaps mix.lock also.

ghost commented 8 years ago

@NobbZ I ran mix credo and it came back with a lot of suggestions. I figure leave those for separate pull requests.

NobbZ commented 8 years ago

Ok, leaving them makes sense for my, thank you for PR.

James Wheaton notifications@github.com schrieb am Do., 25. Feb. 2016 22:57:

@NobbZ https://github.com/NobbZ I ran mix credo and it came back with a lot of suggestions. I figure leave those for separate pull requests.

— Reply to this email directly or view it on GitHub https://github.com/sashaafm/exads/pull/6#issuecomment-189004197.