search

sashafrey / topicmod

This project had been moved to https://github.com/bigartm/bigartm
Other
0 stars 0 forks source link

Extend rpcz_canary_test to cover server-side errors #75

Closed sashafrey closed 10 years ago

sashafrey commented 10 years ago

For rpcz_canary_test the 'Server-side error' means that method SearchServiceImpl::Search doesn't sent the reply (via reply.send), but instead reports an error (via reply.Error).

The goal is to cover this with a unit-test (one more test case in rpcz_canary_test.cc file). The test should verify that the client receives the error code and error message, provided by server via reply.Error(application_error, error_message).

MelLain commented 10 years ago

Maybe so?https://github.com/sashafrey/topicmod/commit/a25d3be6324c8da6e12bee7d5047283885a95015

sashafrey commented 10 years ago

I left the comment in the commit (a25d3be)

MelLain commented 10 years ago

Here's the fix. (https://github.com/sashafrey/topicmod/commit/f3da3272717c9ab54301aa39b7e1343c84794857)

sashafrey commented 10 years ago

Looks good :+1:, I'll integrate ASAP

MelLain commented 10 years ago

Excellent!

What's next? I'd like to have some explanations about issue 73 (maybe for one of the components) and then try to do it.

And one simple question about documentation: there are Master Component and Node controller on figure 2.3. I don't understand, whether there are components of one master node, or Master component is on one computer, and Node controller --- on the another one (master and slave nodes respectively)?

Kind regards, Murat.

20.07.2014, 18:25, "sashafrey" notifications@github.com:

Looks good , I'll integrate ASAP

— Reply to this email directly or view it on GitHub.