Improve thread safety in c_interface

[sashafrey]

At the moment there are several thread-safety issues in c_interface.

1. Shared global variable std::string message (shared across GetRequestLength, CopyRequestResult, DisposeRequest, RequetThetaMatrix, RequestTopicModel, RequestScore).

Current behavior of this functions is undefined if the user issues several request from concurrent threads. I suggest the following fix:

• keep "std::string message" in boost::thread_local_storage. This allows user to use several concurrent threads to issue requests in parallel.
• Remove functions GetRequestLengt and DisposeRequest, because they can be avoided. To achieve this, change RequestXXX functions to return the length of the request instead of the "request id". If request failed, return the error code, which is a negative value - and therefore it can be distinguished from successful request (non-negative return value). Document, that each use thread must use the following sequence to retrieve request: RequestXXX -> allocate buffer -> CopyRequestResult.

Interleaving requests are not valid, e.g. RequestXXX -> RequestYYY -> CopyRequestResult(XXX) -> CopyRequestResult(YYY) is not supported. Indeed, there is no reason for user to do this!

1. ArtmGetLastErrorMessage

Again, use boost::thread_local_storage to keep the last error message.

[JeanPaulShapo]

@sashafrey Could you explain, why std::string error_message is defined as static, while std::string message is not?

[sashafrey]

This is a mistake. Both variables should be defined as static to prevent their usage outside of the c_interface.cc. The following link explains the difference between "global" and "static global" variables. http://bytes.com/topic/c/answers/860211-global-variable-static-global-variable

[sashafrey]

Fixed in https://github.com/sashafrey/topicmod/commit/278550c2c00e259526d48644e668eccfcd6e9ccb