search

sashahafner / biogas

Tools for biogas research in R: process biogas data and predict biogas production
14 stars 4 forks source link

Missing check arguments in cumBgGD function #15

Closed NannaLojborg closed 5 years ago

NannaLojborg commented 5 years ago

In line 14 it says 'Check arguments', but there is nothing there. Check arguments should be added similar to how it is done in cumBg function.

NannaLojborg commented 5 years ago

Check arguments have been added. Though, new changes needs to be reviewed.

sashahafner commented 5 years ago

@NannaLojborg can you check line 60? It still seems to have a missing ). Maybe you didn't include this file in a commit. If you have committed and pushed all changes, I can fix it. Just trying to avoid a merge conflict.

NannaLojborg commented 5 years ago

I have added the missing bracket now. It was line 61 you noticed a missing bracket earlier and a 'c' in line 60. That is why I missed a bracket in line 60, after adding the 'c'.

NannaLojborg commented 5 years ago

@sashahafner All changes have been committed and pushed.

sashahafner commented 5 years ago

Great thanks!

sashahafner commented 5 years ago

Looks good. I made a few minor changes. We need to test it, and for that we should make a data set for testing.