search

sashahart / vex

Run a command in the named virtualenv.
MIT License
372 stars 26 forks source link

do not define virtualenv interpreter per default #18

Closed schlamar closed 10 years ago

schlamar commented 10 years ago

This is a saner default than the current behavior IMO and solves #11 for me.

sashahart commented 10 years ago

You're right insofar as this should have been fixed when handle_make was created, the intention is pretty clear in handle_make.

However, I think it's important to note that it doesn't solve #11 (assuming provisionally that there is an issue to fix there). specifying --python python SHOULD work - if python is on PATH. If it's not on PATH then unfortunately nothing can divine what PATH should have been. In general, simply failing to support --python is not acceptable. But if it is an issue with user configuration that vex cannot safely modify then it is not a bug with vex. EIther there is no problem or the problem continues in spite of this specific change.

schlamar commented 10 years ago

This solves #11 partially because vex -m myenv works now. Only vex -m --python=python myenv does not work (yet).

sashahart commented 10 years ago

It doesn't solve #11 at all because supporting --python is not optional and the "fix" isn't based on an understanding of that problem.