search

sashas777 / bug-from-email

Fix for Magento 2.2.4 GitHub Issue #14952 (https://github.com/magento/magento2/issues/14952)
35 stars 16 forks source link

Upgrade plugin to work with 2.2.6 #6

Closed tsukasa1989 closed 6 years ago

tsukasa1989 commented 6 years ago

How to update this plugin to work on 2.2.6 which still has the issue looking at the ticket: https://github.com/magento/magento2/issues/14952

Would like to upgrade my Magento to 2.2.6 with this extension.

KM-HM commented 6 years ago

You could try to install the files manually, the composer settings of this modul do not allow composer to install this module in Magento 2.2.6. A limitation that was introduced in the hopes that Magento Team would fix this bug in the next patch.

djamps commented 6 years ago

FYI - After removing bug-from-email and upgrading to 2.2.6, it appears the issue may be finally resolved. We are seeing the correct "FROM" address without the bug-from-email module.

sashas777 commented 6 years ago

@tsukasa1989 @kemexyz @djamps

So should I update to 2.2.6 or it is fixed there?

djamps commented 6 years ago

@sashas777 I am not seeing any more email issues on 2.2.6 both for orders and contact form, but I haven't tested every function yet.

matthew99 commented 6 years ago

I had this installed on 2.2.4 and 2.2.5, and removed your plugin in order to update to 2.2.6. However, the bug is still there: no sender (FROM) in transactional email - at least not in the copies sent. See also https://github.com/magento/magento2/issues/14952 there's a few others. I am using Magical SMTP extension as well - their testmails do arrive with FROM So it may be a great idea to update the plugin to work with 2.2.6

sashas777 commented 6 years ago

@matthew99 Okay, I going to update it for 2.2.6 Thanks for the feedback