Added support for file_search/ranking_options and results responses, additional error states

sashirestela / simple-openai

A Java library to use the OpenAI Api in the simplest possible way.

MIT License

182 stars 17 forks source link

Added support for file_search/ranking_options and results responses, additional error states #183

Closed amavashev closed 2 months ago

amavashev commented 2 months ago

Added support for file_search/ranking_options and file_search/results responses, additional error states. As per: https://platform.openai.com/docs/api-reference/run-steps/step-object

sashirestela commented 2 months ago

@amavashev Thanks for using simple-openai and for being proactive to contribute to this project. I would like to suggest some points before creating a PR:

Create a PR after some minimal discussion to be on the same page.
Follow all the steps in the Contributing guideline. Though Configure IDE is optional, it is very helpful.
If you create a PR, don't change the project version.

That said, I'm working on this topic and considering some related stuff, so I think you are duplicating efforts.

Best regards

amavashev commented 2 months ago

Ok, will do.

sashirestela commented 2 months ago

@amavashev Before you close your PR, I would like to know where you find these additional values? I ask you because in the OpenAI technical documentation (which has been updated two days ago) I can't find your "invalid_image" option:

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

amavashev commented 2 months ago

@amavashev Before you close your PR, I would like to know where you find these additional values? I ask you because in the OpenAI technical documentation (which has been updated two days ago) I can't find your "invalid_image" option:

We see these during actual runtime. had to add these additional error codes to avoid JSON serialization errors.

sashirestela commented 2 months ago

@amavashev I'm afraid that I haven't been clear enough with my previous messages. What I meant is that you have to stop working on this PR because I'm already working on implementing the full new functionality (https://github.com/sashirestela/simple-openai/issues/182). My suggestions were for next contributions. Sorry for any confusion.

amavashev commented 2 months ago

Ok I am not working on this PR. I can close it.