search

sashs / Ropper

Display information about files in different file formats and find gadgets to build rop chains for different architectures (x86/x86_64, ARM/ARM64, MIPS, PowerPC, SPARC64). For disassembly ropper uses the awesome Capstone Framework.
https://scoding.de/ropper
BSD 3-Clause "New" or "Revised" License
1.88k stars 206 forks source link

Fix _createNumberNeg printing values out of order on x86 #118

Closed ddlws closed 4 years ago

ddlws commented 4 years ago

x86 ropchains print out of order if _createNumberNeg is used.

Before patch: rop += rebase_0(0x00024a67) # 0xf7d92a67: pop eax; ret; rop += rebase_0(0x00019aee) # 0xf7d87aee: neg eax; ret; rop += p(0xffffff83)

After: rop += rebase_0(0x00024a67) # 0xf7d92a67: pop eax; ret; rop += p(0xffffff83) rop += rebase_0(0x00019aee) # 0xf7d87aee: neg eax; ret;

sashs commented 4 years ago

Thanks. Merged!