sashs / filebytes

Library to read and edit files in the following formats: Executable and Linking Format (ELF), Portable Executable (PE), MachO and OAT (Android Runtime)
https://scoding.de/filebytes-introduction
BSD 3-Clause "New" or "Revised" License
126 stars 25 forks source link

Further development of the lib #16

Closed KOLANICH closed 5 years ago

KOLANICH commented 5 years ago

Hi again.

When developing a tool FrozenTable.py editing a data structure in cpython binaries, I had to create some modules it may make some sense to integrate them into your tool

sashs commented 5 years ago

Hi,

what do you mean with integrate? Do you mean the classes should be reimplemented by using your modules?

KOLANICH commented 5 years ago

what do you mean with integrate?

I mean to add my abstraction layer to your lib, blend the code and merge the classes. Remove everything redundant, taking the best impl available.

sashs commented 5 years ago

The idea behind filebytes is to have no further dependencies. I implemented this lib for ropper since there was no other lib that fit to my needs. If you want you can implement some functionality in my modules, but it is important to have no dependencies.

KOLANICH commented 5 years ago

If you want you can implement some functionality in my modules, but it is important to have no dependencies.

Are "vendorized" ( copied into the module dir) dependencies counted as dependencies?

sashs commented 5 years ago

I would suggest clone the repo and show me what you mean. Just copy your modules into this repo does not make sense. However, your ExecutableFormat class could be merged with the Binary class. Your ELFMachine.py Module has other external dependencies.